Connection pool & round robin strategy #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @var array | ||
| */ | ||
| protected $connections; |
There was a problem hiding this comment.
Please use the $_ convention for all protected functions.
|
This is a very nice and long expected addition (also see #357 and #333). Please adjust the code to the coding standards (see my comments). For the tests I would suggest some more extensive tests on also "real" failing connections or also adding connection to IP's which don't exist and see what happens. |
|
Fixed |
ruflin
added a commit
that referenced
this pull request
Aug 12, 2014
Connection pool & round robin strategy
|
Merged. Thanks a lot for this addition. I think this was long awaited :-) |
|
As far as I can see, most of this pull request is covered by your contribution: https://github.com/ruflin/Elastica/pull/357/files Can I close this one or is anything missing? |
|
I think you can close it. |
|
Ok, will close it. |
This was referenced Jun 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection pool and some simple strategies with tests.